#1128 — S15.2.2.1_A2_T5 should use Date.prototype.getFullYear()

bug_id: 1128
creation_ts: 2012-12-14 06:43:00 -0800
short_desc: S15.2.2.1_A2_T5 should use Date.prototype.getFullYear()
delta_ts: 2013-06-13 07:24:29 -0700
product: Test262
component: ECMA-262 Tests
version: unspecified
rep_platform: All
op_sys: All
bug_status: RESOLVED
resolution: FIXED
priority: Normal
bug_severity: normal
everconfirmed: true
reporter: André Bargull
assigned_to: Brent Baker
cc: ["brbaker", "prsriniv", "trbaker"]

commentid: 3009
comment_count: 0
who: André Bargull
bug_when: 2012-12-14 06:43:54 -0800

getYear() is listed in Annex B, test case should use getFullYear() instead.

commentid: 4061
comment_count: 1
who: Brent Baker
bug_when: 2013-05-17 11:15:05 -0700

NOTE: Annex section B lists non-standard functions, so even though
Date.prototype.getYear( ) is implemented in some implementations, it is NOT
part of the standard and should NOT be included in the standard testsuite.

http://www.ecma-international.org/ecma-262/5.1/#sec-B.2.4

I'll provide a patch that removes this usage.

commentid: 4075
comment_count: 2
attachid: 38
who: Brent Baker
bug_when: 2013-05-20 06:25:09 -0700

Created attachment 38
do not use Date.prototype.getYear( )

Date.prototype.getYear() is not part of the required specification, instead use Date.prototype.getFullYear()

commentid: 4086
comment_count: 3
attachid: 42
who: Brent Baker
bug_when: 2013-05-21 05:49:37 -0700

Created attachment 42
remove Date.prototype.getYear()|setYear from testsuite

commentid: 4091
comment_count: 4
who: Prashanth Srinivasan
bug_when: 2013-05-21 11:32:26 -0700

Reviewed patch +1

commentid: 4130
comment_count: 5
attachid: 47
who: Brent Baker
bug_when: 2013-06-04 06:54:03 -0700

Created attachment 47
Move getYear() and setYear() into annexB

commentid: 4138
comment_count: 6
attachid: 55
who: Brent Baker
bug_when: 2013-06-05 04:47:28 -0700

Created attachment 55
Move getYear() and setYear() into annexB

Exported change, including commit message

commentid: 4155
comment_count: 7
who: Brent Baker
bug_when: 2013-06-07 04:39:25 -0700

changeset: 370:11a02c1eea0a
user: Brent Baker <brbaker@adobe.com>
date: Thu Jun 06 07:44:11 2013 -0400
summary: Bug 1128: Move getYear() and setYear() into annexB

NOTE: I am still waiting to get access to update the live website @ http://test262.ecmascript.org

commentid: 4179
comment_count: 8
who: André Bargull
bug_when: 2013-06-12 11:28:47 -0700

Not resolved -> test case S15.2.2.1_A2_T5 is still using getYear() instead of getFullYear()

commentid: 4187
comment_count: 9
who: Brent Baker
bug_when: 2013-06-13 07:24:29 -0700

André, thank you for finding this. I mistakenly dropped the change from the patches as I reworked them. I have addressed the issue and did a grep of the testsuite to ensure that I hadn't missed any other instances.

Again thanks for double checking this.

changeset: d067d2f0ca30
tag: tip
user: Brent Baker <brbaker@adobe.com>
date: Thu Jun 13 10:07:45 2013 -0400
files: test/suite/ch15/15.12/15.12.3/15.12.3-11-26.js test/suite/ch15/15.2/15.2.2/S15.2.2.1_A2_T5.js website/json/ch15.json website/json/suiteDescrip.json
description:
Bug 1128: use Date.prototype.getFullYear() in S15.2.2.1_A2_T5
Bug 1131: use String.prototype.charAt() in 15.12.3-11-26

Both of these changes were accidentaly dropped when I regenerated patches for these bugs. I have grepped the testsuite to ensure that the annexB functions only appear in the annexB section of the testsuite.

NOTE: Also regenerated the website based on this change. (Still waiting for permission to actually update the live website)

archives

#1128 — S15.2.2.1_A2_T5 should use Date.prototype.getFullYear()