archives

« Bugzilla Issues Index

#1131 — 15.12.3-11-26 should use String.prototype.substring or String.prototype.charAt

• bug_id: 1131
• creation_ts: 2012-12-15 14:49:00 -0800
• short_desc: 15.12.3-11-26 should use String.prototype.substring or String.prototype.charAt
• delta_ts: 2013-06-13 07:24:50 -0700
• product: Test262
• component: ECMA-262 Tests
• version: unspecified
• rep_platform: All
• op_sys: All
• bug_status: RESOLVED
• resolution: FIXED
• priority: Normal
• bug_severity: normal
• everconfirmed: true
• reporter: André Bargull
• assigned_to: Brent Baker
• cc: ["brbaker", "prsriniv", "trbaker"]

---

• commentid: 3012
• comment_count: 0
• who: André Bargull
• bug_when: 2012-12-15 14:49:07 -0800

The test case uses String.prototype.substr which is listed in Annex B, therefore the test should be rewritten to use either String.prototype.substring or String.prototype.charAt

---

• commentid: 4056
• comment_count: 1
• who: Brent Baker
• bug_when: 2013-05-17 05:28:10 -0700

NOTE: Annex section B lists non-standard functions, so even though String.prototype.substr() is implemented in some implementations, it is NOT part of the standard and should NOT be included in the standard testsuite.

http://www.ecma-international.org/ecma-262/5.1/#sec-B.2.3

I'll provide a patch that removes this usage.

---

• commentid: 4074
• comment_count: 2
• attachid: 37
• who: Brent Baker
• bug_when: 2013-05-20 06:14:53 -0700

Created attachment 37
do not use String.prototype.substr()

Use String.prototype.charAt() instead of substr() since substr() is not actually part of the required spec.

---

• commentid: 4085
• comment_count: 3
• attachid: 41
• who: Brent Baker
• bug_when: 2013-05-21 05:44:47 -0700

Created attachment 41
remove String.prototype.substr() from testsuite

---

• commentid: 4092
• comment_count: 4
• who: Prashanth Srinivasan
• bug_when: 2013-05-21 12:12:18 -0700

Reviewed patch for removing substr() and it looks good.

---

• commentid: 4133
• comment_count: 5
• attachid: 50
• who: Brent Baker
• bug_when: 2013-06-04 10:25:03 -0700

Created attachment 50
Move String.prototype.substr into annexB

---

• commentid: 4141
• comment_count: 6
• attachid: 58
• who: Brent Baker
• bug_when: 2013-06-05 05:02:01 -0700

Created attachment 58
Move String.prototype.substr into annexB

Exported change, including commit message

---

• commentid: 4153
• comment_count: 7
• who: Brent Baker
• bug_when: 2013-06-07 04:38:02 -0700

changeset: 373:579bd85aaf2a
user: Brent Baker <brbaker@adobe.com>
date: Wed Jun 05 08:00:44 2013 -0400
summary: Bug 1131: Move String.prototype.substr into annexB

NOTE: I am still waiting to get access to update the live website @ http://test262.ecmascript.org

---

• commentid: 4180
• comment_count: 8
• who: André Bargull
• bug_when: 2013-06-12 11:29:37 -0700

Not resolved -> test case 15.12.3-11-26 is still using substr() instead of substring() or charAt().

---

• commentid: 4186
• comment_count: 9
• who: Brent Baker
• bug_when: 2013-06-13 04:55:02 -0700

(In reply to comment #8)
> Not resolved -> test case 15.12.3-11-26 is still using substr() instead of
> substring() or charAt().

Eek, I thought I had grepped all of the code, will get this fixed.

---

• commentid: 4188
• comment_count: 10
• who: Brent Baker
• bug_when: 2013-06-13 07:24:50 -0700

André, thank you for finding this. I mistakenly dropped the change from the patches as I reworked them. I have addressed the issue and did a grep of the testsuite to ensure that I hadn't missed any other instances.

Again thanks for double checking this.

changeset: d067d2f0ca30
tag: tip
user: Brent Baker <brbaker@adobe.com>
date: Thu Jun 13 10:07:45 2013 -0400
files: test/suite/ch15/15.12/15.12.3/15.12.3-11-26.js test/suite/ch15/15.2/15.2.2/S15.2.2.1_A2_T5.js website/json/ch15.json website/json/suiteDescrip.json
description:
Bug 1128: use Date.prototype.getFullYear() in S15.2.2.1_A2_T5
Bug 1131: use String.prototype.charAt() in 15.12.3-11-26

Both of these changes were accidentaly dropped when I regenerated patches for these bugs. I have grepped the testsuite to ensure that the annexB functions only appear in the annexB section of the testsuite.

NOTE: Also regenerated the website based on this change. (Still waiting for permission to actually update the live website)