#1189 — “=” instead of “===” in test S13.2_A4_T2

bug_id: 1189
creation_ts: 2013-01-07 14:32:00 -0800
short_desc: “=” instead of “===” in test S13.2_A4_T2
delta_ts: 2013-06-07 04:37:08 -0700
product: Test262
component: ECMA-262 Tests
version: unspecified
rep_platform: All
op_sys: All
bug_status: RESOLVED
resolution: FIXED
priority: Normal
bug_severity: normal
everconfirmed: true
reporter: Martin Bodin
assigned_to: Brent Baker
cc: ["brbaker", "prsriniv", "trbaker"]

commentid: 3110
comment_count: 0
who: Martin Bodin
bug_when: 2013-01-07 14:32:33 -0800

Hi,

I’m not 100% confident that this is actually a bug in the test suite, but I’ve seen in test “S13.2_A4_T1” and “S13.2_A4_T2” (and I guess probably with neighbouring tests...) such a code:
var __constructor_was__enumed;

for (__prop in __gunc.prototype){
if (__prop = 'constructor')
__constructor_was__enumed = true;
}

I actually found them quite surprising. Why putting an assignement there (even if it’s correct with respect to the JavaScript syntax)? It seems to me that it does not serve the current purpose of this test. Of course, I may be misinterpreting this particular test. If it is the case, sorry for the noise.

Here is the code I think should be instead:

for (__prop in __gunc.prototype){
if (__prop === 'constructor')
__constructor_was__enumed = true;
}

Hoping it will help,
Martin.

commentid: 4076
comment_count: 1
who: Brent Baker
bug_when: 2013-05-20 07:44:05 -0700

I agree that the intent of the test is to loop through the prototype of the object and try to find the 'constructor', therefore the if should be "===" not an assignment.

for (__prop in __gunc.prototype){
if (__prop === 'constructor')
__constructor_was__enumed = true;
}

NOTE: This if test is never actually executed since the prototype of the Function object is not enumerable.

http://www.ecma-international.org/ecma-262/5.1/#sec-E
15.3.5.2: In Edition 5, the prototype property of Function instances is not enumerable. In Edition 3, this property was enumerable.

I'll provide a patch to switch the test to use "==="

commentid: 4077
comment_count: 2
attachid: 39
who: Brent Baker
bug_when: 2013-05-20 07:51:19 -0700

Created attachment 39
use "===" instead of "="

I checked other enumeration loops in the ch13/13.2 section and all others are properly using "==="

commentid: 4093
comment_count: 3
who: Prashanth Srinivasan
bug_when: 2013-05-21 12:17:09 -0700

Reviewed patches and is good to go.

commentid: 4152
comment_count: 4
who: Brent Baker
bug_when: 2013-06-07 04:37:08 -0700

changeset: 374:c0b147580eee
user: Brent Baker <brbaker@adobe.com>
date: Fri Jun 07 06:57:45 2013 -0400
summary: Bug 1189: use "===" instead of "=" for S13.2_A4_T1 and T2

NOTE: I am still waiting to get access to update the live website @ http://test262.ecmascript.org

archives

#1189 — “=” instead of “===” in test S13.2_A4_T2