archives

« Bugzilla Issues Index

#2496 — "same" is determined but not used in Map.prototype.set

• bug_id: 2496
• creation_ts: 2014-02-04 06:28:00 -0800
• short_desc: "same" is determined but not used in Map.prototype.set
• delta_ts: 2014-05-13 16:31:52 -0700
• product: Draft for 6th Edition
• component: editorial issue
• version: Rev 22: January 20, 2014 Draft
• rep_platform: All
• op_sys: All
• bug_status: RESOLVED
• resolution: FIXED
• priority: Normal
• bug_severity: enhancement
• everconfirmed: true
• reporter: Jason Orendorff
• assigned_to: Allen Wirfs-Brock
• cc: ecmascript

---

• commentid: 7178
• comment_count: 0
• who: Jason Orendorff
• bug_when: 2014-02-04 06:28:37 -0800

> 6. If M’s [[MapComparator]] internal slot is undefined, then let same be
> the abstract operation SameValueZero.
> 7. Else, let same be the abstract operation SameValue.
> 8. Repeat for each Record {[[key]], [[value]]} p that is an element of
> entries,
> a. If SameValueZero(p.[[key]], key), then
> i. Set p.[[value]] to value.
> ii. Return M.

8.a. should say "If same(...)" not "If SameValueZero(...)".

---

• commentid: 7186
• comment_count: 1
• who: C. Scott Ananian
• bug_when: 2014-02-04 14:35:11 -0800

Actually, I believe that [[MapComparator]] is being removed from the spec. So steps 6 and 7 should just be deleted.

---

• commentid: 7191
• comment_count: 2
• who: Jason Orendorff
• bug_when: 2014-02-05 07:39:14 -0800

I didn't know that! Excellent!

---

• commentid: 7192
• comment_count: 3
• who: Allen Wirfs-Brock
• bug_when: 2014-02-05 07:48:47 -0800

(In reply to comment #2)
> I didn't know that! Excellent!

right, the second argument to the constructors was removed at (I think) the Nov. TC39 meeting.

If somebody wants to have a Map/set that distingishes -0 they can easily create a subclass that does that.