« Bugzilla Issues Index
#2579 — Make Promise.all robust in the face of evil promises and subclasses
- bug_id:
2579
- creation_ts:
2014-03-16 21:19:00 -0700
- short_desc:
Make Promise.all robust in the face of evil promises and subclasses
- delta_ts:
2014-04-06 11:30:54 -0700
- product:
Draft for 6th Edition
- component:
technical issue
- version:
Rev 22: January 20, 2014 Draft
- rep_platform:
All
- op_sys:
All
- bug_status:
RESOLVED
- resolution:
FIXED
- priority:
Normal
- bug_severity:
normal
- everconfirmed:
true
- reporter:
Domenic Denicola
- assigned_to:
Allen Wirfs-Brock
- commentid:
7435
- comment_count:
0
- who:
Domenic Denicola
- bug_when:
2014-03-16 21:19:51 -0700
Diffs:
* Markdown with whitespace: https://github.com/domenic/promises-unwrapping/commit/6fbf10096263270fe29516f6758add41a946f4be
* Markdown without whitespace: https://github.com/domenic/promises-unwrapping/commit/6fbf10096263270fe29516f6758add41a946f4be?w=1
* Rendered: https://github.com/domenic/promises-unwrapping/commit/show/6fbf10096263270fe29516f6758add41a946f4be/04c6e90#diff-04c6e90faac2675aa89e2176d2eec7d8
(Much of the with-whitespace diff is just adding an indentation level for existing code.)
---
See previous discussion at https://github.com/domenic/promises-unwrapping/issues/89
- commentid:
7440
- comment_count:
1
- who:
Allen Wirfs-Brock
- bug_when:
2014-03-18 12:16:23 -0700
fixed in rev23 editor draft.
Note refactored patch to avoid introducing 'done' flag, similar to rev22 version.
- commentid:
7441
- comment_count:
2
- who:
Domenic Denicola
- bug_when:
2014-03-18 12:21:55 -0700
Would love to see the patch so I can be sure it passes the tests :)
- commentid:
7447
- comment_count:
3
- attachid:
70
- who:
Allen Wirfs-Brock
- bug_when:
2014-03-18 15:35:53 -0700
Created attachment 70
Promise.all, as edited
- commentid:
7578
- comment_count:
4
- who:
Allen Wirfs-Brock
- bug_when:
2014-04-06 11:30:54 -0700
fixed in rev23 draft