archives

« Bugzilla Issues Index

#2795 — 15.2.4.2.2 GetOrCreateLoad a.i and a.iv not used


GetOrCreateLoad allows linkSets to contain linked load records. During linking, as each load record is linked, they are cleared from the linkSets (including unlinked LinkSets). This clearing operation would never apply to these already-linked loads so it looks as if linked dependencies in the linkSet may never be cleared possibly resulting in unlinkable linkSets.

It could be much more useful, less wasteful, and avoid this possible bug to let linkSets only contain unlinked load records.

When running ProcessLoadDependencies at the start of a load, dependency Load records with status="linked" could not get added to the linkSet, but rather just added to the dependency list.

Having linkSets as only unlinked load records simplifies the lookups necessary in the linking process as well.

I've done some tests with setting LinkSets to only contain unlinked load records, and everything seems to work out fine. I would need to do further tests to be sure this suggestion is conclusive though.


The implementation does follow exactly this description, linkSets are filtered to not contain linked load records due to 15.2.4.6.1 (5).

Renaming this issue, to reflect the fact that 15.2.4.2.2 GetOrCreateLoad 5a i and 5a iv are never used anywhere since AddDependencyLoad (the only caller of RequestLoad) doesn't make use of this information.


concerns old module spec.