archives

« Bugzilla Issues Index

#3004 — 24.1.1.5 GetValueFromBuffer, 24.1.1.6 SetValueInBuffer: Assertion in step 1 does not take neutered buffers into account

• bug_id: 3004
• creation_ts: 2014-07-08 10:09:00 -0700
• short_desc: 24.1.1.5 GetValueFromBuffer, 24.1.1.6 SetValueInBuffer: Assertion in step 1 does not take neutered buffers into account
• delta_ts: 2014-07-19 18:29:25 -0700
• product: Draft for 6th Edition
• component: technical issue
• version: Rev 25: May 22, 2014 Draft
• rep_platform: All
• op_sys: All
• bug_status: RESOLVED
• resolution: FIXED
• priority: Normal
• bug_severity: normal
• everconfirmed: true
• reporter: André Bargull
• assigned_to: Allen Wirfs-Brock

---

• commentid: 9140
• comment_count: 0
• who: André Bargull
• bug_when: 2014-07-08 10:09:56 -0700

24.1.1.5 GetValueFromBuffer ( arrayBuffer, byteIndex, type, isLittleEndian )
24.1.1.6 SetValueInBuffer ( arrayBuffer, byteIndex, type, value, isLittleEndian )

The assertion in step 1 is not correct when the array buffer object has been neutered.


Suggested alternative:
---
1. Assert: byteIndex is a positive integer.
2. Let block be arrayBuffer’s [[ArrayBufferData]] internal slot.
3. Let byteLength be the value of arrayBuffer’s [[ArrayBufferByteLength]] internal slot.
4. Let elementSize be the Number value of the Element Size value specified in Table 44 for Element Type type.
5. Assert: byteIndex + elementSize ≤ byteLength or block is null.
6. If block is undefined or null, then throw a TypeError exception.
---


Also: Why does GetValueFromBuffer/SetValueInBuffer handle [[ArrayBufferData]] == `undefined`? That case should never happen, right?

---

• commentid: 9196
• comment_count: 1
• who: Allen Wirfs-Brock
• bug_when: 2014-07-14 18:25:25 -0700

fixed in rev26 editor's draft

Get/SetValueFrom/ToBuffer only called on initialized and non-neutered buffers.

---

• commentid: 9383
• comment_count: 2
• who: Allen Wirfs-Brock
• bug_when: 2014-07-19 18:29:25 -0700

fixed in rev26