archives

« Bugzilla Issues Index

#3444 — String.prototype.replace looks up @@replace on 'this'

• bug_id: 3444
• creation_ts: 2014-12-15 12:21:00 -0800
• short_desc: String.prototype.replace looks up @@replace on 'this'
• delta_ts: 2014-12-15 13:37:37 -0800
• product: Draft for 6th Edition
• component: technical issue
• version: Rev 29: December 06, 2014 Draft
• rep_platform: All
• op_sys: All
• bug_status: RESOLVED
• resolution: DUPLICATE
• dup_id: 3425
• priority: Normal
• bug_severity: enhancement
• everconfirmed: true
• reporter: Chris Toshok
• assigned_to: Allen Wirfs-Brock

---

• commentid: 11041
• comment_count: 0
• who: Chris Toshok
• bug_when: 2014-12-15 12:21:26 -0800

right now the algorithm for String.prototype.replace reads:

4. Let replacer be GetMethod(O, @@replace).
5. ReturnIfAbrupt(replacer).
6. If replacer is not undefined, then
a. Return Call(replacer, searchValue, «string, replaceValue»).

With those steps there's no way for the RegExp.prototype[@@replace] code to be called in, e.g. this code:

var re = /hello/;
console.log ("hello, world".replace (re, "goodbye"));

Given that searchValue is passed as the 'this' to replacer, it seems like it @@replace should be looked up on searchValue. i.e.:

4. Let replacer be GetMethod(searchValue, @@replace)

---

• commentid: 11042
• comment_count: 1
• who: Allen Wirfs-Brock
• bug_when: 2014-12-15 13:37:37 -0800

*** This bug has been marked as a duplicate of bug 3425 ***