« Bugzilla Issues Index
#4246 — 15.2.1.15.3 ResolveExport: overzealous assert for ambiguous StarExport resolution
- bug_id:
4246
- creation_ts:
2015-04-02 13:34:00 -0700
- short_desc:
15.2.1.15.3 ResolveExport: overzealous assert for ambiguous StarExport resolution
- delta_ts:
2015-04-03 12:35:40 -0700
- product:
Draft for 6th Edition
- component:
Modules
- version:
Rev 36: March 17, 2015 Release Candidate 3
- rep_platform:
All
- op_sys:
All
- bug_status:
RESOLVED
- resolution:
FIXED
- priority:
Normal
- bug_severity:
enhancement
- everconfirmed:
true
- reporter:
Adam Klein
- assigned_to:
Allen Wirfs-Brock
- cc:
["dherman", "jorendorff", "samth"]
- commentid:
14032
- comment_count:
0
- who:
Adam Klein
- bug_when:
2015-04-02 13:34:30 -0700
In step 10.f.ii of ResolveExport, the following Assert appears:
"Assert: there is more than one * import that includes the requested name."
yet it not until the next step (10.f.iii) that we discover whether or not the assertion holds:
"If resolution.[[module]] and starResolution.[[module]] are not the same Module Record or SameValue(resolution.[[exportName]], starResolution.[[exportName]]) is false, return 'ambiguous'."
At this point, it's entirely possible that resolution === starResolution.
- commentid:
14033
- comment_count:
1
- who:
Allen Wirfs-Brock
- bug_when:
2015-04-02 13:53:42 -0700
I think the Asset will be fine, i9f I just move 10.f.11 and iii into an else clause for 10.f.i
The current assert is really only confusing immediately after the first resolution is found
- commentid:
14034
- comment_count:
2
- who:
Adam Klein
- bug_when:
2015-04-02 13:56:32 -0700
Yes, I agree that that fix will work.
- commentid:
14035
- comment_count:
3
- who:
Allen Wirfs-Brock
- bug_when:
2015-04-02 14:29:33 -0700
fixed in rev37 editor's draft
- commentid:
14109
- comment_count:
4
- who:
Allen Wirfs-Brock
- bug_when:
2015-04-03 12:35:40 -0700
In Rev37