archives

« Bugzilla Issues Index

#4296 — 11.3.3 Intl.NumberFormat.prototype.format

• bug_id: 4296
• creation_ts: 2015-04-16 14:52:00 -0700
• short_desc: 11.3.3 Intl.NumberFormat.prototype.format
• delta_ts: 2015-04-29 09:53:28 -0700
• product: Internationalization - ECMA-402
• component: Specification
• version: Edition 2.0 drafts
• rep_platform: All
• op_sys: All
• bug_status: RESOLVED
• resolution: FIXED
• priority: Normal
• bug_severity: normal
• everconfirmed: true
• reporter: André Bargull
• assigned_to: Rick Waldron
• cc: waldron.rick

---

• commentid: 14251
• comment_count: 0
• who: André Bargull
• bug_when: 2015-04-16 14:52:06 -0700

11.3.3 Intl.NumberFormat.prototype.format

Step 2: Remove colon

Step 2.a.i: Omit "then"

Step 2.a.iv: Omit "the result of"

Step 2.b: Missing .length (and .name property) for bound function (cf. bug 4288)

Step 2.a: Move to separate section? (cf. bug 4288)

---
11.3.3.1 NumberFormat Format Functions

A NumberFormat format function is an anonymous function that takes one argument value, and performs the following steps:

1. Let nf be the this value.
2. Assert: Type(nf) is Object and nf has an [[initializedNumberFormat]] internal slot whose value is true.
3. If value is not provided, let value be undefined.
4. Let x be ToNumber(value).
5. ReturnIfAbrupt(x).
6. Return FormatNumber(nf, x).
---

==========

FormatNumber abstract operation

Step 7: Remove colon

==========

ToRawPrecision abstract operation

Step 8.b: Remove colon

==========

ToRawFixed abstract operation

Step 7: Remove colon

---

• commentid: 14270
• comment_count: 1
• who: Rick Waldron
• bug_when: 2015-04-16 19:42:39 -0700

> Step 2: Remove colon
> Step 2.a.i: Omit "then"

These are remnants of 1st Edition. Today was the deadline and removing colons and the word "then" in a panic all night is not a good use of anyone's time.

---

• commentid: 14271
• comment_count: 2
• who: Rick Waldron
• bug_when: 2015-04-16 19:48:38 -0700

> Step 2.b: Missing .length (and .name property) for bound function (cf. bug 4288)
> Step 2.a: Move to separate section? (cf. bug 4288)

> 11.3.3.1 NumberFormat Format Functions
...


Added

---

• commentid: 14334
• comment_count: 3
• who: André Bargull
• bug_when: 2015-04-29 09:06:01 -0700

(In reply to Rick Waldron from comment #1)
> > Step 2: Remove colon
> > Step 2.a.i: Omit "then"
>
> These are remnants of 1st Edition. Today was the deadline and removing
> colons and the word "then" in a panic all night is not a good use of
> anyone's time.

Sure, I understand that. That's just minor nit-picking to align the style with ES2015, but it's totally up to you if you want to mimic Allen's style from ES2015. You're the editor of the ECMA-402 spec, so I'm also ok if you prefer a different style or if you say you don't care about these things. (TBH, actually I don't even care about most editorial issues. I do report them, but I think technical issues are by far more interesting.)

---

• commentid: 14341
• comment_count: 4
• who: Rick Waldron
• bug_when: 2015-04-29 09:53:28 -0700

(In reply to André Bargull from comment #3)
> (In reply to Rick Waldron from comment #1)
> > > Step 2: Remove colon
> > > Step 2.a.i: Omit "then"
> >
> > These are remnants of 1st Edition. Today was the deadline and removing
> > colons and the word "then" in a panic all night is not a good use of
> > anyone's time.
>
> Sure, I understand that. That's just minor nit-picking to align the style
> with ES2015, but it's totally up to you if you want to mimic Allen's style
> from ES2015. You're the editor of the ECMA-402 spec, so I'm also ok if you
> prefer a different style or if you say you don't care about these things.
> (TBH, actually I don't even care about most editorial issues. I do report
> them, but I think technical issues are by far more interesting.)

I ended up making every single change that you reported ;)